[PATCH] D99575: [ARM] Clarify a comment regarding AArch64. NFC.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 03:28:44 PDT 2021


mstorsjo created this revision.
mstorsjo added reviewers: rnk, efriedma, compnerd.
Herald added subscribers: danielkiss, hiraditya, kristof.beyls.
mstorsjo requested review of this revision.
Herald added a project: LLVM.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99575

Files:
  llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp


Index: llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp
===================================================================
--- llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp
+++ llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp
@@ -29,7 +29,7 @@
 public:
   ARMWinCOFFObjectWriter(bool Is64Bit)
     : MCWinCOFFObjectTargetWriter(COFF::IMAGE_FILE_MACHINE_ARMNT) {
-    assert(!Is64Bit && "AArch64 support not yet implemented");
+    assert(!Is64Bit && "AArch64 is an entirely different target");
   }
 
   ~ARMWinCOFFObjectWriter() override = default;
@@ -49,7 +49,7 @@
                                               bool IsCrossSection,
                                               const MCAsmBackend &MAB) const {
   assert(getMachine() == COFF::IMAGE_FILE_MACHINE_ARMNT &&
-         "AArch64 support not yet implemented");
+         "AArch64 is an entirely different target");
 
   MCSymbolRefExpr::VariantKind Modifier =
     Target.isAbsolute() ? MCSymbolRefExpr::VK_None : Target.getSymA()->getKind();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99575.334100.patch
Type: text/x-patch
Size: 1045 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210330/a8145c99/attachment.bin>


More information about the llvm-commits mailing list