[PATCH] D99538: [MC][ARM] add .w suffixes for ORN/ORNS T1

Tue Mar 30 03:04:56 PDT 2021

DavidSpickett added inline comments.

================
Comment at: llvm/test/MC/ARM/basic-thumb2-instructions.s:1883
         orns r4, r5, r6
+        orns.w r4, r5, r6
         orn r4, r5, r6, lsl #5
----------------
Initially I thought that we shouldn't be allowing the flag setting S variant for v7 since it's not listed in the documentation. However that's just because on v7 they always set the flags so S or not it's the same thing.

================
Comment at: llvm/test/MC/ARM/basic-thumb2-instructions.s:1888
         orns r4, r5, r6, asr #5
         orn r4, r5, r6, ror #5

----------------
Add a .w check for one or more of the shift variants and the immediate.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99538/new/

https://reviews.llvm.org/D99538