[PATCH] D99569: [AArch64][SVE] Fix vectoriser bug where predicated stores were dropped

Joe Ellis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 02:08:10 PDT 2021


joechrisellis created this revision.
Herald added subscribers: psnobl, hiraditya, kristof.beyls, tschuett.
Herald added a reviewer: efriedma.
joechrisellis requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This commit fixes a bug where loop vectoriser interleaving made an
invalid transform with SVE.

Code such as:

  1	void foo(int *restrict data1, int *restrict data2)
  2	{
  3	  int counter = 1024;
  4	  while (counter--)
  5	    if (data1[counter] > data2[counter])
  6	      data1[counter] = data2[counter];
  7	}

... was previously transformed in such a way that the predicated store
implied by:

  if (data1[counter] > data2[counter])

... was lost, resulting in bad codegen.

This bug was causing of some tests in llvm-test-suite to fail when built
for SVE.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99569

Files:
  llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
  llvm/test/Transforms/LoopVectorize/AArch64/scalarize-store-with-predication.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99569.334081.patch
Type: text/x-patch
Size: 5105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210330/64b3ccd9/attachment.bin>


More information about the llvm-commits mailing list