[PATCH] D99376: [AMDGPU] Mark additional VOP3 as commutable

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D99376#2656686 <https://reviews.llvm.org/D99376#2656686>, @Joe_Nash wrote:

> Reverted since I don't fully understand the issue. It passed all tests on my system, but then upon rebasing top of tree it didn't. So I suspect the commutes may not be deterministic/ well constrained.

I have a bad suspicion here: that is not OK to just commute source modifiers for SDWA. A DST_OP_SEL shares bits with $src0_modifiers, so it needs to be transferred to the new src0 modifiers and masked in src1. I suspect it does not happen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99376/new/

https://reviews.llvm.org/D99376