[PATCH] D99351: [CSSPGO] Top-down processing order based on full profile.

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/ProfiledCallGraph.h:73
+      // further result in an SCC order incompatible with the purely
+      // context-based one, wchich may in turn block context-based inlining.
       for (auto &Child : Caller->getAllChildContext()) {
----------------
typo: which


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1605
+  if (!ProfileTopDownLoad && UseProfiledCallGraph)
+    errs() << "WARNING: -use-profiled-call-graph ignored, should be used "
+              "together with -sample-profile-top-down-load.\n";
----------------
Is this the canonical way of emit warning? Or something through diagnostics like `LLVMContext.diagnose(DiagnosticInfoSampleProfile(..., DS_Warning))`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99351/new/

https://reviews.llvm.org/D99351