[PATCH] D99561: Support visitor pattern by PointerUnion.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 29 21:51:19 PDT 2021


mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/ADT/PointerUnion.h:262
+      assert(false); // NOLINT
+#endif
+    }
----------------
Other places in ADT are including `#include "llvm/Support/ErrorHandling.h"` and using `llvm_unreachable` directly. You should be able to do the same here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99561/new/

https://reviews.llvm.org/D99561



More information about the llvm-commits mailing list