[PATCH] D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing added inline comments.


================
Comment at: llvm/lib/ObjectYAML/XCOFFEmitter.cpp:13
+//===----------------------------------------------------------------------===//
+#include "llvm/ADT/StringSwitch.h"
+#include "llvm/BinaryFormat/XCOFF.h"
----------------
Do we need this header file? I guess what we need is `DenseMap` ?


================
Comment at: llvm/lib/ObjectYAML/XCOFFEmitter.cpp:127
+  InitFileHdr.NumberOfSymTableEntries = Obj.Symbols.size();
+  for (XCOFFYAML::Symbol YamlSym : Obj.Symbols)
+    InitFileHdr.NumberOfSymTableEntries += YamlSym.NumberOfAuxEntries;
----------------



================
Comment at: llvm/test/tools/yaml2obj/XCOFF/basic-doc.yaml:24-29
+  - Name:            .file
+    Value:           0x0
+    Section:         N_DEBUG
+    Type:            0x0
+    StorageClass:    C_FILE
+    NumberOfAuxEntries: 1
----------------
It looks that the `Value`, `Type`, `StorageClass` and `NumberOfAuxEntries` are optional too. Could you please add some test cases for them as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95505/new/

https://reviews.llvm.org/D95505