[PATCH] D74588: Use DISABLE_LLVM_LINK_LLVM_DYLIB for TableGenTests

Mon Mar 29 18:45:03 PDT 2021

beanz added a comment.

In D74588#2654289 <https://reviews.llvm.org/D74588#2654289>, @aaronpuchert wrote:

> In D74588#2654185 <https://reviews.llvm.org/D74588#2654185>, @beanz wrote:
>
>> I think this bug is the other way around. LLVMTableGenGlobalISel should not be using `DISABLE_LLVM_LINK_LLVM_DYLIB`.
>
> The commit message of rL373651 <https://reviews.llvm.org/rL373651> says
>
>> Fixed the -DLLVM_LINK_LLVM_DYLIB=ON using DISABLE_LLVM_LINK_LLVM_DYLIB when creating the library. Apparently it automatically links to libLLVM.dylib and we don't want that from tablegen.

This makes no sense. The tablegen tool build disables linking the dylib, which should be sufficient. We should never need to force it on a static archive. I’m 99% sure, that rL373651 <https://reviews.llvm.org/rL373651> is just wrong here, and that the solution to all of this is to just remove `DISABLE_LLVM_LINK_LLVM_DYLIB` from the library.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74588/new/

https://reviews.llvm.org/D74588