[PATCH] D99138: [deref] Use readonly to infer global dereferenceability in a callee

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 29 17:27:28 PDT 2021


reames planned changes to this revision.
reames added a comment.

Realized the refactored code has a serious code smell.  Not a bug per se, but not something I want to check in.

NoSync requires no coordination.  ReadOnly simply implies this thread isn't initiating coordination.  Another thread could be signaling, and this thread could be in a spin loop.

The only reason this isn't an active bug is that we consider all atomic ordered reads to also write.

I'm going to roll this back to the previous version.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99138/new/

https://reviews.llvm.org/D99138



More information about the llvm-commits mailing list