[PATCH] D99546: [llvm][ValueMap] Share the value map between MappingContext

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 29 15:38:33 PDT 2021


steven_wu added a comment.

@pcc @tejohnson I tried to fix the assertion failure shown in the test case (reduced from actual code generated from swift compiler) by simplifying the ValueMapper but I couldn't quite get the comdat tests to pass. I think comdat is relying on some of the indirect symbol that doesn't appear in the ValueMap for the normal context but I couldn't quite figure out how that works. Any suggestion?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99546/new/

https://reviews.llvm.org/D99546



More information about the llvm-commits mailing list