[PATCH] D93125: Update AMDGPU PAL usage documentation

[Colin Hughes via Phabricator via llvm-commits]

cohughes added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:11251
 
-  `amdgpu_gfx` Function calls are currently in development and are
-  subject to major changes.
+  Currently, USER_DATA_0 and USER_DATA_1 are reserved for the GlobalTable
+  and PerShaderTable addresses respectively, and should be programmed
----------------
t-tye wrote:
> cohughes wrote:
> > cohughes wrote:
> > > t-tye wrote:
> > > > Is USER_DATA_0 and USER_DATA_1 defined somewhere?
> > > Specifically, it refers to SPI_SHADER_USER_DATA_*_0 (based on the shader stage) and COMPUTE_USER_DATA_0.
> > Also, we refer to "any USER_DATA" register right above this with the same kind of generalization. Not sure if its worth being super specific or not. 
> In the text above it refers to "user data registers" but here it says "USER_DATA_1". So I suggest being consistent. If USER_DATA_1 is not a identifier defined somewhere else then do not use it here, use the "user data register 1" terminology used in the proceeding paragraphs.
Actually, I think I like your suggestion. I'll update it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93125/new/

https://reviews.llvm.org/D93125