[PATCH] D93125: Update AMDGPU PAL usage documentation

Jake Merdich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 29 15:26:06 PDT 2021


JakeMerdichAMD added a comment.

Chiming in: they specifically refer to `mmCOMPUTE_USER_DATA_0` and `mmSPI_SHADER_USER_DATA_{STAGE}_0`, which are in the public chip register offsets (not anywhere in LLVM right now, but present in PAL, Mesa, and any public chip register spec). I don't think we should explicitly define those values here, but using those names might make it a bit more specific and easier to find.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93125/new/

https://reviews.llvm.org/D93125



More information about the llvm-commits mailing list