[PATCH] D99531: [x86] enhance matching of pmaddwd

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 29 12:40:09 PDT 2021


craig.topper added a comment.

This seems reasonable. Is it possible we also need to handle the case where all the extract indices from a different subvector of the input? It's hard to say from the test case that we started from since it appears to have a logic mistake that exposed the bug in the first place. It used "sizeof sizeof(__r) in its loop control which caused the loop bounds to be 4. Seems like it should have been sizeof(__r)/sizeof(int16_t).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99531/new/

https://reviews.llvm.org/D99531



More information about the llvm-commits mailing list