[PATCH] D58521: [DAGCombiner] allow truncation of binops after legalization if desirable

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 29 12:04:24 PDT 2021


spatel added a comment.

In D58521#2656581 <https://reviews.llvm.org/D58521#2656581>, @lebedev.ri wrote:

> Re x86 - do we really want to narrow all the way to bytes?
> I was under impression that wasn't a good idea.

It's probably not a good idea in general, but the diffs I scanned here are all feeding into 8-bit op/store, so should be neutral.
This patch is trying to remove code and help SystemZ without hurting anything else, but maybe it's not worth the churn. We could probably add a TLI hook instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58521/new/

https://reviews.llvm.org/D58521



More information about the llvm-commits mailing list