[PATCH] D99342: [flang] Fix CHECK() calls on erroneous procedure declarations

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld added inline comments.


================
Comment at: flang/lib/Semantics/resolve-names.cpp:686
+    Symbol *genericSymbol{genericInfo_.top().symbol};
+    CHECK(genericSymbol);
+    return *genericSymbol;
----------------
klausler wrote:
> `return DEREF(genericSymbol);`
Thanks!


================
Comment at: flang/lib/Semantics/resolve-names.cpp:688
+    return *genericSymbol;
+  }
   // Add to generic the symbol for the subprogram with the same name
----------------
tskeith wrote:
> This could be just: `return DEREF(genericInfo_.top().symbol);`
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99342/new/

https://reviews.llvm.org/D99342