[PATCH] D99385: [lld-macho] Add addition debug info

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

will do the rest of the review when the diff is ready :)



================
Comment at: lld/MachO/Dwarf.cpp:65
+  auto &msec = static_cast<const MachODWARFSection &>(sec);
+  if (msec.isec == nullptr)
+    return llvm::None;
----------------
apparently the convention (not my personal favorite) is to do nullchecks this way


================
Comment at: lld/MachO/Dwarf.cpp:69
+  const Reloc *found = nullptr;
+  // FIXME: relocs might be sorted already? (in which case, better to bisct?)
+  for (const auto &reloc : msec.isec->relocs) {
----------------
I don't think the Mach-O format guarantees they're sorted


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99385/new/

https://reviews.llvm.org/D99385