[PATCH] D99444: [ADT] Introduce lazy unique iterator
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 29 09:54:25 PDT 2021
dblaikie added a comment.
Yeah, not entirely sure this abstraction carries its weight. (I was going to suggest the set could be moved from the iterator into a range object (rather than using iterator_range) but then copies of the iterator wouldn't be independent (only one of them would visit a given element and the other would skip it) & then that starts to make me worry about the abstraction in general - making the iterators a bit big/expensive to copy/etc)
Perhaps there are some more use cases you could highlight/migrate to demonstrate the value?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99444/new/
https://reviews.llvm.org/D99444
More information about the llvm-commits
mailing list