[PATCH] D99351: [CSSPGO] Top-down processing order based on full profile.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

In D99351#2656191 <https://reviews.llvm.org/D99351#2656191>, @wenlei wrote:

> In D99351#2654984 <https://reviews.llvm.org/D99351#2654984>, @hoy wrote:
>
>> In D99351#2654965 <https://reviews.llvm.org/D99351#2654965>, @wmi wrote:
>>
>>> Seems there is still build error:
>>>
>>> lib/Transforms/IPO/SampleProfile.cpp:1692:23: error: no matching constructor for initialization of 'llvm::sampleprof::ProfiledCallGraph'
>>>
>>>   ProfiledCallGraph ProfiledCG;
>>>
>>> include/llvm/Transforms/IPO/ProfiledCallGraph.h:43:3: note: candidate constructor not viable: requires 2 arguments, but 0 were provided
>>>
>>>   ProfiledCallGraph(StringMap<FunctionSamples> &ProfileMap,
>>
>> Oh I see. I didn't sync to Wenlei's latest patch whee the profiled callgraph construction was moved into the constructor. Since there is a subtle difference about whether to limit the call graph build to nodes with samples only, I'm adding back the default constructor for now. We can discuss how to make the code well shared.
>
> Let me commit my change so this can also move forward (sorry for delay). I was thinking about adding another ctor for profiled call graph for AutoFDO case (would require changes in this patch). But we could also move the graph building into a helper function..

Sounds good. We can do the refactoring in the current change. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99351/new/

https://reviews.llvm.org/D99351