[PATCH] D99382: Add -disable-verify flag to llvm-link.

Mon Mar 29 09:43:04 PDT 2021

nickwasmer added a comment.

In D99382#2652212 <https://reviews.llvm.org/D99382#2652212>, @tejohnson wrote:

> How about a test like llvm/test/LTO/X86/strip-debug-info.ll? Could something similar be done to test llvm-link?

I wasn't quite able to get that trick to work. With llvm-link I just get a "warning: ignoring invalid debug info in <stdin>" whether the input is assembled by `llvm-link` or by `llvm-as -disable-verify`, or `opt -disable-verify -disable-upgrade-debug-info` (the .bc file is the same).

The case where it would behave differently is checked by a `CHECK-ERR` which is never set as any check-prefix. I also don't see any documentation or code in FileCheck that makes `-ERR` a special suffix like `-LABEL` and `-DAG` are.

Looking into the history, I think this test is no longer testing that `-disable-verify` works that way as of git commit a8b2ddbde453fab0db90be21b9a1ff961a7770e0 which removed the CHECK-ERR run.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99382/new/

https://reviews.llvm.org/D99382