[PATCH] D99347: [AMDGPU] Set implicit arg attributes for indirect calls

Jon Chesterfield via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 29 08:32:20 PDT 2021


JonChesterfield resigned from this revision.
JonChesterfield added a comment.

I don't understand why fine grained attributes would be introduced and then all the fine grained attributes set on the function. I also don't understand why setting the attributes on a function based on which they call is considered difficult. We don't seem to be reaching consensus. I'll leave the assessment of this patch to others.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99347/new/

https://reviews.llvm.org/D99347



More information about the llvm-commits mailing list