[PATCH] D99509: [RISCV] Add legality check for vectoring redunction

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.h:132
+                                   ElementCount VF) const {
+    if (!VF.isScalable())
+      return true;
----------------
We support the fixed-length vector reductions. Can we add support for that too?


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.h:151
+    case RecurKind::UMax:
+    case RecurKind::FMin:
+    case RecurKind::FMax:
----------------
We don't support the fmin/fmax reductions yet. I suspect this would crash in the backend?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99509/new/

https://reviews.llvm.org/D99509