[PATCH] D99507: [amdgpu] Add a pass to avoid jump into blocks with 0 exec mask.

Michael Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 29 07:54:59 PDT 2021


hliao added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIAvoidZeroExecMask.cpp:19
+// In case the mask to be restored needs reloading at the beginning of a block,
+// relax the eager exec mask evaluation in the corresponding predecessor block.
+//
----------------
foad wrote:
> I don't know what you mean by "relax" here.
> 
> This comment doesn't explain //why// you'd want to do this transformation.
just add comment on the motivation of this pass. Will put the details in the source code then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99507/new/

https://reviews.llvm.org/D99507



More information about the llvm-commits mailing list