[PATCH] D99277: [AsmParser][SystemZ][z/OS] Add in support to accept "#" as part of an Identifier token

Mon Mar 29 07:34:56 PDT 2021

abhina.sreeskantharajan accepted this revision.
abhina.sreeskantharajan added a comment.
This revision is now accepted and ready to land.

In D99277#2655770 <https://reviews.llvm.org/D99277#2655770>, @anirudhp wrote:

> In D99277#2655519 <https://reviews.llvm.org/D99277#2655519>, @abhina.sreeskantharajan wrote:
>
>> There is one failing mlir unit test which I suspect might be caused by this patch and should be fixed.
>
> Its //probably// these 2 commits and not because of my commit: https://reviews.llvm.org/rGf6e0fc2ddd8e9286e52a9931c833a64366a1ba41 and https://reviews.llvm.org/rGbc888a0fd61aa3a34102593867f76b5600c7a61e. It was fixed recently. I might have to rebase on latest master just to be consistent.

oh you're right, those are more likely to be the cause. It would be good to rebase and double-check. The changes LGTM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99277/new/

https://reviews.llvm.org/D99277