[PATCH] D99074: [llvm][AArch64][SVE] Fold literals into math instructions

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 29 07:28:15 PDT 2021


DavidTruby added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:2247
 
+  /// Compact single bit fp immediates
+  multiclass intrinsic_compact_fp_immediates<string I, string IZ, string IX,
----------------
david-arm wrote:
> Hi @DavidTruby, this is quite a lot of very similar looking patterns to maintain here. Is there a possible way to condense them somehow, i.e. the A and B patterns are duplicates, so you could invoke a multiclass for A, then a multiclass for B?
@david-arm hopefully this helps a bit, it at least means that each pattern is only mentioned once so only need changing once if they have to be changed in future


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99074/new/

https://reviews.llvm.org/D99074



More information about the llvm-commits mailing list