[PATCH] D98981: [SLP] allow matching integer min/max intrinsics as reduction ops

Mon Mar 29 05:50:50 PDT 2021

spatel added a comment.

In D98981#2654940 <https://reviews.llvm.org/D98981#2654940>, @mkazantsev wrote:

> I confirm that with this version of patch the original failure is gone. For me it looks fine, but I'm not a compitent reviewer to approve it because I don't know SLP well enough. Thanks!

Thanks again for fuzz testing this! I can't say if there are more corner-cases that I haven't accounted for.
If we can't get this right, an alternative approach would be to give up on trying to handle both forms (cmp+select and intrinsic) of min/max. We could change SLP to only recognize min/max intrinsics simultaneously with the patch for instcombine that canonicalizes to those forms.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98981/new/

https://reviews.llvm.org/D98981