[PATCH] D99493: [SimpleLoopUnswitch] Add tests to check partially invariant unswitch

Mon Mar 29 05:49:04 PDT 2021

fhahn added a comment.

In D99493#2655555 <https://reviews.llvm.org/D99493#2655555>, @jaykang10 wrote:

> In D99493#2655532 <https://reviews.llvm.org/D99493#2655532>, @thakis wrote:
>
>> Looks like this test fails: http://45.33.8.238/linux/42881/step_12.txt
>
> um... that's what I was concerned about pushing this patch... because this test relies on https://reviews.llvm.org/D99354. Do I have to revert this patch or something like that? @thakis Can you let me know what I have to do please?

Sorry for not being clear. You should pre-commit the tests for D99354 <https://reviews.llvm.org/D99354> with the checks for the IR generated by *current* trunk. Then update D99354 <https://reviews.llvm.org/D99354> so the diff only shows the impact of the patch. You should never commit a patch with tests that do *not* pass.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99493/new/

https://reviews.llvm.org/D99493