[PATCH] D99451: Use write_basic_package_version_file for LLVM

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

Here are some diffs I get depending on having this patch or not:

  > diff build-all-builtins/runtimes/runtimes-i386-unknown-linux-gnu-bins/CMakeCache.txt build-all-builtins.fail/runtimes/runtimes-i386-unknown-linux-gnu-bins/CMakeCache.txt
  290c290,293
  < COMPILER_RT_ENABLE_WERROR:BOOL=ON
  ---
  > COMPILER_RT_ENABLE_WERROR:BOOL=OFF
  >
  > //Path where built compiler-rt executables should be stored.
  > COMPILER_RT_EXEC_OUTPUT_DIR:PATH=/repo/llvm-project/llvm/build-all-builtins/runtimes/runtimes-i386-unknown-linux-gnu-bins/compiler-rt/bin
  300c303,306
  < COMPILER_RT_INCLUDE_TESTS:BOOL=ON
  ---
  > COMPILER_RT_INCLUDE_TESTS:BOOL=OFF
  >
  > //Path where built compiler-rt libraries should be installed.
  > COMPILER_RT_INSTALL_PATH:PATH=/compiler-clang
  307a314,316
  > //Path where built compiler-rt libraries should be stored.
  > COMPILER_RT_OUTPUT_DIR:PATH=/repo/llvm-project/llvm/build-all-builtins/runtimes/runtimes-i386-unknown-linux-gnu-bins/compiler-rt
  >
  313a323,328
  > //Compiler to use for testing
  > COMPILER_RT_TEST_COMPILER:PATH=/repo/llvm-project/llvm/build-all-builtins/./bin/clang
  >
  > //C++ Compiler to use for testing
  > COMPILER_RT_TEST_CXX_COMPILER:PATH=/repo/llvm-project/llvm/build-all-builtins/./bin/clang++
  >
  426c441
  < LIBCXXABI_LIBCXX_LIBRARY_PATH:PATH=/repo/llvm-project/llvm/build-all-builtins/./lib/i386-unknown-linux-gnu/c++
  ---
  > LIBCXXABI_LIBCXX_LIBRARY_PATH:PATH=/i386-unknown-linux-gnu/c++
  805,807d819
  < //Executor to use when running tests.
  < LIBUNWIND_EXECUTOR:STRING=/app/vbuild/RHEL7-x86_64/python/3.8.0/bin/python3.8 /repo/llvm-project/libunwind/../libcxx/utils/run.py
  <
  847,849d858
  < //TargetInfo to use when setting up test environment.
  < LIBUNWIND_TARGET_INFO:STRING=libcxx.test.target_info.LocalTI
  <
  900c909
  < LLVM_DIR:PATH=/repo/llvm-project/llvm/build-all-builtins/lib/cmake/llvm
  ---
  > LLVM_DIR:PATH=/proj/flexasic/app/llvm/3.8/share/llvm/cmake
  922a932,934
  > //Enable compiler warnings.
  > LLVM_ENABLE_WARNINGS:BOOL=ON
  >
  1148c1160
  < CMAKE_NUMBER_OF_MAKEFILES:INTERNAL=47
  ---
  > CMAKE_NUMBER_OF_MAKEFILES:INTERNAL=38

LLVM_DIR does not point to my build tree when it fails.
And LIBCXXABI_LIBCXX_LIBRARY_PATH looks quite different as it is an incomplete path when it fails.
Not sure if that is a clue or not, but seems a bit strange.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99451/new/

https://reviews.llvm.org/D99451