[PATCH] D88785: Support {S,U}REMEqFold before legalization

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:5455
 
   // If MUL is unavailable, we cannot proceed in any case.
+  if (!DCI.isBeforeLegalizeOps() && !isOperationLegalOrCustom(ISD::MUL, VT))
----------------



================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:5631
 
   if (isOperationLegalOrCustom(ISD::VSELECT, SETCCVT)) {
     // If we have a vector select, let's replace the comparison results in the
----------------
What about this one?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:5641
   // Else, we can just invert the comparison result in the appropriate lanes.
   if (isOperationLegalOrCustom(ISD::XOR, SETCCVT))
     return DAG.getNode(ISD::XOR, DL, SETCCVT, NewCC,
----------------
What about this one?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:5886-5889
   if (!isOperationLegalOrCustom(ISD::SETEQ, VT) ||
       !isOperationLegalOrCustom(ISD::AND, VT) ||
       !isOperationLegalOrCustom(Cond, VT) ||
       !isOperationLegalOrCustom(ISD::VSELECT, VT))
----------------
What about these?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88785/new/

https://reviews.llvm.org/D88785