[PATCH] D99451: Use write_basic_package_version_file for LLVM

Mon Mar 29 02:10:54 PDT 2021

phosek added a comment.

I tried doing a local build using the same version of CMake we use on our bots but it still doesn't reproduce so there must be some other factor.

In D99451#2655119 <https://reviews.llvm.org/D99451#2655119>, @bjope wrote:

> We are also seeing problems with this when rebasing downstream. A somewhat strange thing was that it worked if I invoked the build a second time without removing my build directory in between. But with at clean (non existing) build dir I got failures.
> I thought that it maybe was something wrong with my merge (or just a downstream problem), but if others also see problems with this then maybe not. Anyway, if I revert this patch things works fine again.
>
> Just wanted to highlight that one might need to remove the build dir between tests when trying to reproduce the problem as my experience is that when invoking the build a second time it might pass. So some kind of dependency problem perhaps?

In our case we always do a clean build on bots so I'm not sure if it's the same issue.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99451/new/

https://reviews.llvm.org/D99451