[PATCH] D98232: [regalloc] Ensure Query::collectInterferringVregs is called before interval iteration

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

While i'm personally not very neurotic regarding compile time,
and agree with @dmgreen that `-O3` is by design allowed to consume more time,
here i have to agree with @nikic.

5% compile-time regression is a rather significant time investment.
What does it bring? If it's less than 1% in some obscure proprietary benchmark
then it's one thing, if it's a few percent here and there in SPEC it's another.

In fact, i would strongly insist to follow llvm best practices,
revert the original patch that this patch is trying to fix,
fold this fix into the original change, and post that as a new review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98232/new/

https://reviews.llvm.org/D98232