[PATCH] D64827: [Xtensa 2/10] Add Xtensa ELF definitions.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 29 00:10:18 PDT 2021


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one test nit. You might want to give it a couple of days to see if any of the other reviewers have further comments to make.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/xtensa-header-flags.test:9-12
+# ALL:     Flags [
+# INSN:     EF_XTENSA_XT_INSN (0x100)
+# LIT:      EF_XTENSA_XT_LIT  (0x200)
+# ALL:     ]
----------------
No need for the extra indentation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64827/new/

https://reviews.llvm.org/D64827



More information about the llvm-commits mailing list