[PATCH] D99478: [Orc] Fix mismatched C-API header function signatures

[Mats Larsen via Phabricator via llvm-commits]

supergrecko created this revision.
supergrecko added a reviewer: lhames.
Herald added a reviewer: deadalnix.
Herald added a subscriber: hiraditya.
supergrecko requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

LLVMOrcDisposeObjectLayer and LLVMOrcExecutionSessionGetJITDylibByName did not have matching signatures between the C-API header and binding implementations. Fixes PR49745


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99478

Files:
  llvm/include/llvm-c/Orc.h
  llvm/lib/ExecutionEngine/Orc/OrcV2CBindings.cpp


Index: llvm/lib/ExecutionEngine/Orc/OrcV2CBindings.cpp
===================================================================
--- llvm/lib/ExecutionEngine/Orc/OrcV2CBindings.cpp
+++ llvm/lib/ExecutionEngine/Orc/OrcV2CBindings.cpp
@@ -393,7 +393,7 @@
   delete unwrap(JTMB);
 }
 
-void lLVMOrcDisposeObjectLayer(LLVMOrcObjectLayerRef ObjLayer) {
+void LLVMOrcDisposeObjectLayer(LLVMOrcObjectLayerRef ObjLayer) {
   delete unwrap(ObjLayer);
 }
 
Index: llvm/include/llvm-c/Orc.h
===================================================================
--- llvm/include/llvm-c/Orc.h
+++ llvm/include/llvm-c/Orc.h
@@ -339,8 +339,7 @@
  * ownership has not been passed to a JITDylib (e.g. because some error
  * prevented the client from calling LLVMOrcJITDylibAddGenerator).
  */
-void LLVMOrcDisposeDefinitionGenerator(
-    LLVMOrcDefinitionGeneratorRef DG);
+void LLVMOrcDisposeDefinitionGenerator(LLVMOrcDefinitionGeneratorRef DG);
 
 /**
  * Dispose of a MaterializationUnit.
@@ -388,7 +387,9 @@
  * Returns the JITDylib with the given name, or NULL if no such JITDylib
  * exists.
  */
-LLVMOrcJITDylibRef LLVMOrcExecutionSessionGetJITDylibByName(const char *Name);
+LLVMOrcJITDylibRef
+LLVMOrcExecutionSessionGetJITDylibByName(LLVMOrcExecutionSessionRef ES,
+                                         const char *Name);
 
 /**
  * Return a reference to a newly created resource tracker associated with JD.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99478.333746.patch
Type: text/x-patch
Size: 1400 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210328/8f70eb76/attachment.bin>