[PATCH] D99351: [CSSPGO] Top-down processing order based on full profile.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

In D99351#2654704 <https://reviews.llvm.org/D99351#2654704>, @wmi wrote:

> In D99351#2654236 <https://reviews.llvm.org/D99351#2654236>, @hoy wrote:
>
>> In D99351#2654048 <https://reviews.llvm.org/D99351#2654048>, @wmi wrote:
>>
>>> Just find ProfiledCallGraph.h is not included in the patch so the build failed after applying the patch.
>>
>> Thanks for trying it. You’ll also need to apply Wenlei’s patch D99146 <https://reviews.llvm.org/D99146>.
>
> Then I run into the cyclic including issue:
> In this patch llvm/Transforms/IPO/SampleContextTracker.h includes llvm/Transforms/IPO/ProfiledCallGraph.h while in D99146 <https://reviews.llvm.org/D99146> llvm/Transforms/IPO/ProfiledCallGraph.h includes llvm/Transforms/IPO/SampleContextTracker.h.

I see. Sounds like the inclusion of ProfiledCallGraph.h should be moved into SampleContextTracker.cpp, and `SampleContextTracker.h` will need to have a forward declaration of `class ProfiledCallGraph`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99351/new/

https://reviews.llvm.org/D99351