[PATCH] D98232: [regalloc] Ensure Query::collectInterferringVregs is called before interval iteration
Mircea Trofin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 28 13:54:34 PDT 2021
mtrofin added a comment.
In D98232#2654676 <https://reviews.llvm.org/D98232#2654676>, @xbolva00 wrote:
> Extra compile time is fine for -O3 if it improves a runtime performance of various benchmarks.
>
> 3-5% extra compile time for almost no visible perf gain is bad trade off and not only Rust folks would be disapointed.
@xbolva00 - sorry if I'm missing it, but what changes would you like made?
All - note that this patch just changes defaults (well, and fixes an underlying problem).
It sounds like we don't have data on the frequency of the potential code quality regression. Would looking at a suite of benchmarks, including compression and eigen, on x86 (in a thinlto + FDO build, in an isolated environment) help advance the discussion - or what's an alternative?
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98232/new/
https://reviews.llvm.org/D98232
More information about the llvm-commits
mailing list