[PATCH] D99460: [X86][update_llc_test_checks] Use a less greedy regular expression for replacing constant pool labels in tests.
Pengfei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 28 01:48:09 PDT 2021
pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: llvm/test/CodeGen/X86/WidenArith.ll:14
; X86-NEXT: vandps %ymm1, %ymm0, %ymm0
-; X86-NEXT: vandps {{\.LCPI.*}}, %ymm0, %ymm0
+; X86-NEXT: vandps {{\.LCPI[0-9]+_[0-9]+}}, %ymm0, %ymm0
; X86-NEXT: retl
----------------
craig.topper wrote:
> pengfei wrote:
> > Nit: Should this be simplified to [0-9_]+?
> We could but I thought it was best to keep it in sync with the scrub regex
>
> ```
> SCRUB_X86_LCP_RE = re.compile(r'\.LCPI[0-9]+_[0-9]+')
> ```
Agreed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99460/new/
https://reviews.llvm.org/D99460
More information about the llvm-commits
mailing list