[PATCH] D99460: [X86][update_llc_test_checks] Use a less greedy regular expression for replacing constant pool labels in tests.

Sat Mar 27 16:47:29 PDT 2021

craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel, MaskRay.
Herald added subscribers: pengfei, arphaman, arichardson.
craig.topper requested review of this revision.
Herald added a project: LLVM.

While working on D97208 <https://reviews.llvm.org/D97208> I noticed that these greedy regular
expressions prevent tests from failing when (%rip) appears after
a constant pool label when it didn't before.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99460

Files:
  llvm/test/CodeGen/X86/WidenArith.ll
  llvm/test/CodeGen/X86/addsub-constant-folding.ll
  llvm/test/CodeGen/X86/atomic-fp.ll
  llvm/test/CodeGen/X86/avx-cmp.ll
  llvm/test/CodeGen/X86/avx-intrinsics-x86-upgrade.ll
  llvm/test/CodeGen/X86/avx2-arith.ll
  llvm/test/CodeGen/X86/avx2-conversions.ll
  llvm/test/CodeGen/X86/avx2-intrinsics-x86.ll
  llvm/test/CodeGen/X86/avx2-nontemporal.ll
  llvm/test/CodeGen/X86/avx2-shift.ll
  llvm/test/CodeGen/X86/avx2-vbroadcasti128.ll
  llvm/test/CodeGen/X86/avx2-vector-shifts.ll
  llvm/test/CodeGen/X86/avx512-intrinsics-fast-isel.ll
  llvm/test/CodeGen/X86/avx512-intrinsics.ll
  llvm/test/CodeGen/X86/avx512bw-intrinsics.ll
  llvm/test/CodeGen/X86/avx512bwvl-intrinsics.ll
  llvm/test/CodeGen/X86/avx512vbmi2-funnel-shifts.ll
  llvm/test/CodeGen/X86/avx512vbmi2vl-funnel-shifts.ll
  llvm/test/CodeGen/X86/avx512vl-intrinsics-fast-isel.ll
  llvm/test/CodeGen/X86/avx512vl-intrinsics-upgrade.ll
  llvm/test/CodeGen/X86/bitreverse.ll
  llvm/test/CodeGen/X86/broadcast-elm-cross-splat-vec.ll
  llvm/test/CodeGen/X86/cmov-fp.ll
  llvm/test/CodeGen/X86/cmp.ll
  llvm/test/CodeGen/X86/code-model-elf.ll
  llvm/test/CodeGen/X86/combine-bextr.ll
  llvm/test/CodeGen/X86/combine-bitreverse.ll
  llvm/test/CodeGen/X86/combine-multiplies.ll
  llvm/test/CodeGen/X86/extractelement-fp.ll
  llvm/test/CodeGen/X86/fast-isel-fneg.ll
  llvm/test/CodeGen/X86/fildll.ll
  llvm/test/CodeGen/X86/fma-scalar-combine.ll
  llvm/test/CodeGen/X86/fmf-flags.ll
  llvm/test/CodeGen/X86/fp-cvt.ll
  llvm/test/CodeGen/X86/fp-intrinsics.ll
  llvm/test/CodeGen/X86/fp-stack-set-st1.ll
  llvm/test/CodeGen/X86/fp-strict-scalar-fptoint.ll
  llvm/test/CodeGen/X86/fp-strict-scalar-inttofp.ll
  llvm/test/CodeGen/X86/fp128-cast.ll
  llvm/test/CodeGen/X86/fp128-i128.ll
  llvm/test/CodeGen/X86/fp80-strict-scalar.ll
  llvm/test/CodeGen/X86/fptosi-sat-scalar.ll
  llvm/test/CodeGen/X86/fptoui-sat-scalar.ll
  llvm/test/CodeGen/X86/funnel-shift-rot.ll
  llvm/test/CodeGen/X86/haddsub-broadcast.ll
  llvm/test/CodeGen/X86/half.ll
  llvm/test/CodeGen/X86/hoist-and-by-const-from-lshr-in-eqcmp-zero.ll
  llvm/test/CodeGen/X86/hoist-and-by-const-from-shl-in-eqcmp-zero.ll
  llvm/test/CodeGen/X86/i64-to-float.ll
  llvm/test/CodeGen/X86/insert-into-constant-vector.ll
  llvm/test/CodeGen/X86/insertelement-var-index.ll
  llvm/test/CodeGen/X86/known-bits-vector.ll
  llvm/test/CodeGen/X86/known-signbits-vector.ll
  llvm/test/CodeGen/X86/limited-prec.ll
  llvm/test/CodeGen/X86/masked_gather_scatter.ll
  llvm/test/CodeGen/X86/memcmp-minsize.ll
  llvm/test/CodeGen/X86/memcmp-more-load-pairs.ll
  llvm/test/CodeGen/X86/memcmp-optsize.ll
  llvm/test/CodeGen/X86/memcmp-pgso.ll
  llvm/test/CodeGen/X86/memcmp.ll
  llvm/test/CodeGen/X86/merge-consecutive-loads-256.ll
  llvm/test/CodeGen/X86/merge-consecutive-loads-512.ll
  llvm/test/CodeGen/X86/mmx-arith.ll
  llvm/test/CodeGen/X86/mmx-fold-zero.ll
  llvm/test/CodeGen/X86/neg_fp.ll
  llvm/test/CodeGen/X86/nontemporal.ll
  llvm/test/CodeGen/X86/packss.ll
  llvm/test/CodeGen/X86/peep-test-1.ll
  llvm/test/CodeGen/X86/pointer-vector.ll
  llvm/test/CodeGen/X86/popcnt.ll
  llvm/test/CodeGen/X86/pr15309.ll
  llvm/test/CodeGen/X86/pr34080-2.ll
  llvm/test/CodeGen/X86/pr34605.ll
  llvm/test/CodeGen/X86/pr40539.ll
  llvm/test/CodeGen/X86/pr40891.ll
  llvm/test/CodeGen/X86/pr46527.ll
  llvm/test/CodeGen/X86/pr47299.ll
  llvm/test/CodeGen/X86/rotate-extract-vector.ll
  llvm/test/CodeGen/X86/scalar-fp-to-i64.ll
  llvm/test/CodeGen/X86/scalar-int-to-fp.ll
  llvm/test/CodeGen/X86/select-of-fp-constants.ll
  llvm/test/CodeGen/X86/select.ll
  llvm/test/CodeGen/X86/setcc-lowering.ll
  llvm/test/CodeGen/X86/shrink-fp-const2.ll
  llvm/test/CodeGen/X86/shrink_vmul.ll
  llvm/test/CodeGen/X86/sink-addsub-of-const.ll
  llvm/test/CodeGen/X86/slow-pmulld.ll
  llvm/test/CodeGen/X86/sse-fcopysign.ll
  llvm/test/CodeGen/X86/sse-load-ret.ll
  llvm/test/CodeGen/X86/sse1-fcopysign.ll
  llvm/test/CodeGen/X86/sse1.ll
  llvm/test/CodeGen/X86/sse2.ll
  llvm/test/CodeGen/X86/sse3.ll
  llvm/test/CodeGen/X86/uint64-to-float.ll
  llvm/test/CodeGen/X86/uint_to_fp-2.ll
  llvm/test/CodeGen/X86/uint_to_fp-3.ll
  llvm/test/CodeGen/X86/urem-power-of-two.ll
  llvm/test/CodeGen/X86/var-permute-256.ll
  llvm/test/CodeGen/X86/vec-strict-fptoint-128.ll
  llvm/test/CodeGen/X86/vec-strict-inttofp-128.ll
  llvm/test/CodeGen/X86/vec-strict-inttofp-256.ll
  llvm/test/CodeGen/X86/vec-strict-inttofp-512.ll
  llvm/test/CodeGen/X86/vec_fabs.ll
  llvm/test/CodeGen/X86/vec_fneg.ll
  llvm/test/CodeGen/X86/vec_fpext.ll
  llvm/test/CodeGen/X86/vec_fptrunc.ll
  llvm/test/CodeGen/X86/vec_logical.ll
  llvm/test/CodeGen/X86/vec_partial.ll
  llvm/test/CodeGen/X86/vec_reassociate.ll
  llvm/test/CodeGen/X86/vec_shift4.ll
  llvm/test/CodeGen/X86/vector-fshl-128.ll
  llvm/test/CodeGen/X86/vector-fshl-rot-128.ll
  llvm/test/CodeGen/X86/vector-fshl-rot-sub128.ll
  llvm/test/CodeGen/X86/vector-fshr-128.ll
  llvm/test/CodeGen/X86/vector-fshr-rot-128.ll
  llvm/test/CodeGen/X86/vector-fshr-rot-sub128.ll
  llvm/test/CodeGen/X86/vector-gep.ll
  llvm/test/CodeGen/X86/vector-idiv-v2i32.ll
  llvm/test/CodeGen/X86/vector-lzcnt-128.ll
  llvm/test/CodeGen/X86/vector-lzcnt-256.ll
  llvm/test/CodeGen/X86/vector-mul.ll
  llvm/test/CodeGen/X86/vector-rotate-128.ll
  llvm/test/CodeGen/X86/vector-sext.ll
  llvm/test/CodeGen/X86/vector-shift-ashr-128.ll
  llvm/test/CodeGen/X86/vector-shift-ashr-256.ll
  llvm/test/CodeGen/X86/vector-shift-ashr-sub128.ll
  llvm/test/CodeGen/X86/vector-shift-lshr-128.ll
  llvm/test/CodeGen/X86/vector-shift-lshr-256.ll
  llvm/test/CodeGen/X86/vector-shift-lshr-sub128.ll
  llvm/test/CodeGen/X86/vector-shift-shl-128.ll
  llvm/test/CodeGen/X86/vector-shift-shl-256.ll
  llvm/test/CodeGen/X86/vector-shift-shl-sub128.ll
  llvm/test/CodeGen/X86/vector-shuffle-avx512.ll
  llvm/test/CodeGen/X86/vector-shuffle-combining-avx2.ll
  llvm/test/CodeGen/X86/vector-shuffle-combining-avx512f.ll
  llvm/test/CodeGen/X86/vector-shuffle-combining-xop.ll
  llvm/test/CodeGen/X86/vector-shuffle-combining.ll
  llvm/test/CodeGen/X86/vector_splat-const-shift-of-constmasked.ll
  llvm/test/CodeGen/X86/vshift-6.ll
  llvm/test/CodeGen/X86/widen_load-2.ll
  llvm/test/CodeGen/X86/x86-shifts.ll
  llvm/test/CodeGen/X86/xop-mask-comments.ll
  llvm/test/CodeGen/X86/xor.ll
  llvm/utils/UpdateTestChecks/asm.py