[PATCH] D74588: Use DISABLE_LLVM_LINK_LLVM_DYLIB for TableGenTests

Sat Mar 27 14:15:05 PDT 2021

aaronpuchert added a comment.

In D74588#2654185 <https://reviews.llvm.org/D74588#2654185>, @beanz wrote:

> I think this bug is the other way around. LLVMTableGenGlobalISel should not be using `DISABLE_LLVM_LINK_LLVM_DYLIB`.

The commit message of rL373651 <https://reviews.llvm.org/rL373651> says

> Fixed the -DLLVM_LINK_LLVM_DYLIB=ON using DISABLE_LLVM_LINK_LLVM_DYLIB when creating the library. Apparently it automatically links to libLLVM.dylib and we don't want that from tablegen.

Originally it didn't have this option and was an object library in @dsanders' original change D68288 <https://reviews.llvm.org/D68288>. But at that time we couldn't use object libraries because older CMake versions were still supported. (See the discussion on the change.)

By now I think we require CMake 3.14 and could go back to the object library?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74588/new/

https://reviews.llvm.org/D74588