[PATCH] D99451: Use write_basic_package_version_file for LLVM

Sat Mar 27 10:19:59 PDT 2021

alexreinking added a comment.

In D99451#2654142 <https://reviews.llvm.org/D99451#2654142>, @steveire wrote:

>> Also adds the file to the build tree, which the comments suggested would happen, but wasn't.
>
> I don't think this is true. Even before your patch, the generated `LLVMConfigVersion.cmake` is in `${CMAKE_BINARY_DIR}/lib/cmake/llvm` which is where it should be? That location is what enables using `find_package` with the `CMAKE_PREFIX_PATH` pointing at the build dir.

There are `LLVMConfig.cmake` files in both `${CMAKE_CURRENT_BINARY_DIR}/CMakeFiles/LLVMConfig.cmake` and `${llvm_cmake_builddir}/LLVMConfig.cmake`, so there should be `LLVMConfigVersion.cmake` files next to both as well.

I'll update the command to use `PACKAGE_VERSION`.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99451/new/

https://reviews.llvm.org/D99451