[PATCH] D99450: [OCaml][Test] Fix and enable debuginfo.ml test.

Josh Berdine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 27 03:18:08 PDT 2021


jberdine accepted this revision.
jberdine added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/bindings/ocaml/debuginfo/llvm_debuginfo.ml:262
 external dibuild_get_or_create_type_array :
   lldibuilder -> data:Llvm.llmetadata array -> Llvm.llmetadata
   = "llvm_dibuild_get_or_create_type_array"
----------------
I wonder if this diff indicates that this `data` label ought to be e.g. `types` instead, to help avoid similar mistakes in the future? A counter-argument is that the LLVM-C header uses  `Data`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99450/new/

https://reviews.llvm.org/D99450



More information about the llvm-commits mailing list