[PATCH] D98701: StackProtector: insert check before `musttail` call.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 26 16:03:17 PDT 2021


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

LGTM with comment nit.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1713
+    // has no register moves of its own and should be the split point.
+    do {
+      --Previous;
----------------
An example of what code you're looking for in this comment would be helpful.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98701/new/

https://reviews.llvm.org/D98701



More information about the llvm-commits mailing list