[PATCH] D99441: [CSSPGO][NFC] Fix a debug dump issue.

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 26 15:54:08 PDT 2021


wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

In D99441#2653927 <https://reviews.llvm.org/D99441#2653927>, @hoy wrote:

> In D99441#2653814 <https://reviews.llvm.org/D99441#2653814>, @wenlei wrote:
>
>> The printing and the wording were intentional - here we're promoting a context, and it doesn't have to be a context with profile. I wanted to capture the tree transformation, not limited to nodes with profile.
>
> I see. If there's a descendent node with a profile along the current path, the tree transformation can be captured by the promotion of the descendent later? The printing AVs because of a null `ToNode->getFunctionSamples()`.

Oh, I didn't notice the AV. In that case, avoid AV is more important. Thanks for the fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99441/new/

https://reviews.llvm.org/D99441



More information about the llvm-commits mailing list