[PATCH] D99376: [AMDGPU] Mark additional VOP3 as commutable

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec accepted this revision.
rampitec added a comment.

In D99376#2653815 <https://reviews.llvm.org/D99376#2653815>, @rampitec wrote:

> In D99376#2653800 <https://reviews.llvm.org/D99376#2653800>, @Joe_Nash wrote:
>
>> remove sub as commutative and add add_lshl.
>> Its pretty bizarre to me that no testing cared if sub was commutative.
>
> Check SIInstrInfo::commuteOpcode(). If there is no Commutable_REV<> it just will not be commuted.
> But I also now have question how does that work if these opcodes do not define it?

Ah, I see. If there is no Commutable_Rev it will just return itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99376/new/

https://reviews.llvm.org/D99376