[PATCH] D99351: [CSSPGO] Top-down processing order based on full profile.

Fri Mar 26 14:00:05 PDT 2021

hoy added a comment.

In D99351#2653712 <https://reviews.llvm.org/D99351#2653712>, @wmi wrote:

> The change is an enhancement to https://reviews.llvm.org/D95988 so it is better to mention D95988 <https://reviews.llvm.org/D95988> in the description/commit log.
>
> Before this patch UseProfileIndirectCallEdges is true for non-CS sampleFDO, now UseProfiledCallGraph is false by default so it change the behavior of non-CS sampleFDO. I will test UseProfiledCallGraph==true for non-CS sampleFDO and if performance is ok, we can enable UseProfiledCallGraph by default. How does it sound?

In D99351#2653712 <https://reviews.llvm.org/D99351#2653712>, @wmi wrote:

> The change is an enhancement to https://reviews.llvm.org/D95988 so it is better to mention D95988 <https://reviews.llvm.org/D95988> in the description/commit log.
>
> Before this patch UseProfileIndirectCallEdges is true for non-CS sampleFDO, now UseProfiledCallGraph is false by default so it change the behavior of non-CS sampleFDO. I will test UseProfiledCallGraph==true for non-CS sampleFDO and if performance is ok, we can enable UseProfiledCallGraph by default. How does it sound?

Sound good, thanks for testing it for non-CS!

BTW, `UseProfileIndirectCallEdges` was true by default but only worked with CS FDO, like `if (UseProfileIndirectCallEdges && ProfileIsCS)`, because the support of adding indirect call edges for non-CS was not done.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99351/new/

https://reviews.llvm.org/D99351