[PATCH] D99305: [docs] Document our norms around reverts

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/docs/DeveloperPolicy.rst:321
+
+When should you revert someone else's change?
+
----------------
reames wrote:
> rupprecht wrote:
> > The two sections here seem to contradict each other:
> > - If you think the author would revert the change, you should revert the change. (Also, you should generally assume that the author would agree to a revert, based on guidance in the previous section that authors should usually revert if when asked).
> > - You should not revert a change until you've started a discussion
> > 
> > I think if you look at the details, they don't contract each other. But at a high level, they do. That should be cleared up.
> I really don't see the contradiction.  These two are written with different audiences in mind, and the former is deliberately inclusive of someone choosing not to revert and leaving the choice to the commit author.  (Say because it would require potentially reverting a whole bunch of changes.)
I suspect the sentence below "In general, if the author themselves would revert the change per these guidelines, we encourage other contributors to do so as a favor to the author" intends to say that if a bot is broken, the author should revert, but so should anyone who notice and identifies the faulty commit.


> If you think the author would revert the change, you should revert the change. 

Maybe the nuance is that this is not a "should" but a "may" here.

The difference I personally make is one of "urgency": if something is badly broken, I'll revert. If I have concerns and I wish for a revert, I'll express my concerns and ask the author to revert temporarily.

> You should not revert a change until you've started a discussion

Was it in reference to an older version of the patch? The text says below: "Reverts should be reasonably timely.  A change submitted two hours ago can be reverted without prior discussion".



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99305/new/

https://reviews.llvm.org/D99305