[PATCH] D98884: [IR] Ignore bitcasts of function pointers which are only used as callees in callbase instruction

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

I think this GlobalOpt patch is a separate change from the original one and needs to go first.



================
Comment at: llvm/lib/Transforms/IPO/GlobalOpt.cpp:2149
+      for (User *BU : U->users())
+        SetCallBaseFastCallingConv(BU);
+      continue;
----------------
rampitec wrote:
> You do not check that user is a callee.
> You do not check that user is a callee.

And the original code does not check it either. This also warrants a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98884/new/

https://reviews.llvm.org/D98884