[PATCH] D99388: [AArch64][GlobalISel] Combine funnel shifts to rotates.
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 26 09:50:43 PDT 2021
aemerson added inline comments.
================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:3894-3895
+ : TargetOpcode::G_ROTR));
+ MI.RemoveOperand(1);
+ MI.getOperand(2).setReg(ShiftReg);
+ Observer.changedInstr(MI);
----------------
foad wrote:
> I think all you have to do here is `MI.RemoveOperand(2)`. That'll move the previous operand 3 into position 2, won't it?
Yes, this is a vestigial piece from the AArch64 version of this combine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99388/new/
https://reviews.llvm.org/D99388
More information about the llvm-commits
mailing list