[PATCH] D99383: [GlobalISel] Add G_ROTR and G_ROTL opcodes for rotates

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:1581-1582
   }
+  case TargetOpcode::G_ROTR:
+  case TargetOpcode::G_ROTL: {
+    LLT Src1Ty = MRI->getType(MI->getOperand(1).getReg());
----------------
foad wrote:
> Why are these different from G_SHL etc, which don't have any special checking here?
We don't allow vector shifts to have scalar shift values right? Seems like an oversight on the G_SHL verifiers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99383/new/

https://reviews.llvm.org/D99383