[PATCH] D86222: Fix PR46880: Fail CHECK-NOT with undefined variable

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: llvm/test/FileCheck/dump-input/annotations.txt:633
+; SUBST-POS-NEXT:check:1'2                             with "DEF_MATCH2" equal to "def-match2"
+; SUBST-POS-NEXT:check:2'0     X error: match failed for invalid pattern
+; SUBST-POS-NEXT:check:2'1                             undefined variable: UNDEF
----------------
jdenny wrote:
> Please restore the correct alignment here and elsewhere in this file.
> 
> (I'm starting to think it might have been better to use `-strict-whitespace` in most of these tests.  I find myself turning it on temporarily anyway while adjusting tests because the squashed whitespace makes debugging confusing.  My original goal for leaving it off was to make test updates easier if we were to adjust formatting, but that rarely happens.  What do you think?)
If whitespace is important it should be on. If formatting changes then we do want things to fail where whitespace is important.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86222/new/

https://reviews.llvm.org/D86222