[PATCH] D98934: [SVE][CostModel] Add instruction cost for operations on scalable vectors

[David Sherwood via Phabricator via llvm-commits]

david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM with nit addressed!



================
Comment at: llvm/test/Analysis/CostModel/AArch64/sve-fpext.ll:10
+define void @sve_fpext() {
+  ; CHECK-LABEL: 'sve_fpext'
+  ; CHECK: Cost Model: Found an estimated cost of 1 for instruction:   %nxv2_f16_to_f32 = fpext <vscale x 2 x half> undef to <vscale x 2 x float>
----------------
CarolineConcatto wrote:
> I believe you can remove the space before ;
> and I think you can use CHECK-NEXT
nit: Can you address @CarolineConcatto's comment before merging? For example, I think all these tests just a need a simple sed replace:

  sed -i 's/  ;CHECK/; CHECK/g'



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98934/new/

https://reviews.llvm.org/D98934