[PATCH] D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive

[Isaac Perry via Phabricator via llvm-commits]

I_Perry added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:369
 
+  bool IsInsideTargetDirective();
   void ResolveOmpObjectList(const parser::OmpObjectList &, Symbol::Flag);
----------------
clementval wrote:
> Would be even nicer to have a generic function like `bool IsNestedInDirective(const llvm::omg::Directive dir)` so it can be reused later for other check. Might even be in the common class For OpenACC and OpenMP. 
> 
> No need to do it in this revision but just keep the idea in mind. 
I'm looking into making a more generic function for this purpose as part of this patch, do you know if anyone has implemented anything like `IsNestedInDirective`
already at this point?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91159/new/

https://reviews.llvm.org/D91159